Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single commit API support #5843

Merged
merged 8 commits into from
Feb 3, 2019
Merged

Add single commit API support #5843

merged 8 commits into from
Feb 3, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 25, 2019 •
edited by techknowlogick
Loading

blocked by go-gitea/go-sdk#138

Fixes #5535

@lunny lunny added the modifies/api This PR adds API routes or modifies them label Jan 25, 2019
@lunny lunny added this to the 1.8.0 milestone Jan 25, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2019
lafriks
lafriks reviewed Jan 25, 2019
View reviewed changes
routers/api/v1/repo/commits.go Outdated
)

// GetSingleCommit get a commit via
func GetSingleCommit(c *context.APIContext) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add swagger docs

@lunny lunny changed the title Add single commit API support WIP: Add single commit API support Jan 25, 2019
@lunny
Copy link
Member Author

lunny commented Jan 25, 2019

@lafriks done and will add tests.

@techknowlogick techknowlogick mentioned this pull request Jan 31, 2019
Closed
7 tasks
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2019
@techknowlogick techknowlogick changed the title WIP: Add single commit API support Add single commit API support Feb 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #5843 into master will increase coverage by 0.06%.
The diff coverage is 72.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5843      +/-   ##
==========================================
+ Coverage   38.22%   38.28%   +0.06%     
==========================================
  Files         329      330       +1     
  Lines       48423    48517      +94     
==========================================
+ Hits        18510    18576      +66     
- Misses      27247    27267      +20     
- Partials     2666     2674       +8
Impacted Files Coverage Δ
routers/api/v1/api.go 73.34% <100%> (+0.1%) ⬆️
routers/api/v1/repo/commits.go 71.73% <71.73%> (ø)
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d91bb2...fbb657d. Read the comment docs.

@techknowlogick techknowlogick merged commit ecefa9e into go-gitea:master Feb 3, 2019
@lunny lunny deleted the lunny/single_commit branch February 3, 2019 03:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@tboerger tboerger tboerger approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Get a single commit
6 participants
@lunny @codecov-io @tboerger @techknowlogick @lafriks @GiteaBot