Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reject to 'request changes' #5858

Merged
merged 4 commits into from
Jan 26, 2019
Merged

Rename reject to 'request changes' #5858

merged 4 commits into from
Jan 26, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 26, 2019 •
edited
Loading

Fixes #5857

GitHub also uses 'Request changes'

@codecov-io
Copy link

codecov-io commented Jan 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ac766fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5858   +/-   ##
=========================================
  Coverage          ?   37.86%           
=========================================
  Files             ?      328           
  Lines             ?    48318           
  Branches          ?        0           
=========================================
  Hits              ?    18294           
  Misses            ?    27393           
  Partials          ?     2631

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac766fe...db457ba. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2019
zeripath
zeripath approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make LGTM work?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2019
@0x5c
Copy link
Contributor

0x5c commented Jan 26, 2019

Isn't line 845 also to edit?

@zeripath zeripath added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2019
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 26, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 26, 2019
@techknowlogick
Copy link
Member

make LG-TM work

@techknowlogick techknowlogick merged commit b8a81cb into go-gitea:master Jan 26, 2019
@adelowo adelowo deleted the rename_reject branch January 26, 2019 17:22
zeripath added a commit to zeripath/gitea that referenced this pull request Jan 27, 2019
@zeripath
Fix wording of go-gitea#5858 issue.review.reject string
81c4dff 
As per @lafriks comment this should be: requested changes

Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks pushed a commit that referenced this pull request Jan 27, 2019
@zeripath @lafriks
Fix wording of #5858 issue.review.reject string (#5869)
182a6d6 
As per @lafriks comment this should be: requested changes

Signed-off-by: Andrew Thornton <art27@cantab.net>
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@adelowo @bmackinney
Rename reject to 'request changes' (go-gitea#5858)
d60a700 
* remame reject to 'request changes

* make usee of requested changes in issue's view content
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@zeripath @bmackinney
Fix wording of go-gitea#5858 issue.review.reject string (go-gitea#5869)
b309603 
As per @lafriks comment this should be: requested changes

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Suggestion: rename "Reject" to "Request changes" (or similar)
7 participants
@adelowo @codecov-io @0x5c @techknowlogick @lafriks @zeripath @GiteaBot