Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new release creation API to allow empty target #5870

Merged
merged 4 commits into from
Jan 30, 2019

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 27, 2019

Empty target will create release on default branch, this is also github's behaviour. Fixes #5471

@lafriks lafriks added this to the 1.8.0 milestone Jan 27, 2019
@codecov-io
Copy link

codecov-io commented Jan 27, 2019

Codecov Report

Merging #5870 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5870      +/-   ##
==========================================
- Coverage   38.01%   38.01%   -0.01%     
==========================================
  Files         328      328              
  Lines       48334    48337       +3     
==========================================
- Hits        18375    18373       -2     
- Misses      27321    27325       +4     
- Partials     2638     2639       +1
Impacted Files Coverage Δ
routers/api/v1/repo/release.go 44.94% <100%> (+0.58%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5f6ce...957d651. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@techknowlogick techknowlogick merged commit fada696 into go-gitea:master Jan 30, 2019
@lafriks lafriks deleted the fix/api_new_release branch January 30, 2019 18:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST /api/v1/releases should require target parameter
6 participants