-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support reviews on a deleted file path #5880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5880 +/- ##
==========================================
- Coverage 37.98% 37.97% -0.02%
==========================================
Files 329 329
Lines 48405 48406 +1
==========================================
- Hits 18388 18381 -7
- Misses 27376 27384 +8
Partials 2641 2641
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was a way to avoid checking the error string in its entirety though - this could break over time.
This is actually a good candidate for a test as we can be sure that our targeted git actually works with a test
Fixes #5418