Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reviews on a deleted file path #5880

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 28, 2019

Fixes #5418

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #5880 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5880      +/-   ##
==========================================
- Coverage   37.98%   37.97%   -0.02%     
==========================================
  Files         329      329              
  Lines       48405    48406       +1     
==========================================
- Hits        18388    18381       -7     
- Misses      27376    27384       +8     
  Partials     2641     2641
Impacted Files Coverage Δ
models/issue_comment.go 45.94% <0%> (-0.06%) ⬇️
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1219d46...aa67f8e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2019
@adelowo adelowo changed the title support reviewing on a deleted file path support reviews on a deleted file path Jan 28, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 28, 2019
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way to avoid checking the error string in its entirety though - this could break over time.

This is actually a good candidate for a test as we can be sure that our targeted git actually works with a test

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2019
@lunny lunny merged commit f9d4bd5 into go-gitea:master Feb 1, 2019
@adelowo adelowo deleted the fix_5418 branch February 1, 2019 08:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reply to review comment of deleted file
7 participants