Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Correct footer height if screen-width is to small (fixes #5878) #5889

Merged
merged 1 commit into from
Jan 30, 2019
Merged

UI: Correct footer height if screen-width is to small (fixes #5878) #5889

merged 1 commit into from
Jan 30, 2019

Conversation

EpicCoder
Copy link
Contributor

footer_fix

@codecov-io
Copy link

codecov-io commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #5889 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5889      +/-   ##
=========================================
- Coverage      38%     38%   -0.01%     
=========================================
  Files         328     328              
  Lines       48331   48331              
=========================================
- Hits        18370   18366       -4     
- Misses      27322   27327       +5     
+ Partials     2639    2638       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16678f5...a1f1d6b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2019
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI type/bug labels Jan 29, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 29, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2019
@EpicCoder
Copy link
Contributor Author

Correct small mistake, edited public/less/_base.less to targed only footer and rebased to master to resolve conflicts with public/css/index.css

@EpicCoder EpicCoder changed the title UI: Fix #5878 Correct footer height if screen-width is to small UI: Correct footer height if screen-width is to small (fixes #5878) Jan 30, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@techknowlogick techknowlogick merged commit a967cf9 into go-gitea:master Jan 30, 2019
@EpicCoder EpicCoder deleted the fix-footer-height branch January 30, 2019 10:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EpicCoder @codecov-io @techknowlogick @zeripath @GiteaBot