Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure issue.Poster is loaded in mailIssueCommentToParticipants #5891

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Ensure issue.Poster is loaded in mailIssueCommentToParticipants #5891

merged 1 commit into from
Jan 29, 2019

Conversation

zeripath
Copy link
Contributor

Previous code could potentially dereference nil - this PR ensures
that the poster is loaded before dereferencing it.

Fixes issue reported on Discord by drewG

Signed-off-by: Andrew Thornton art27@cantab.net

@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #5891 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5891   +/-   ##
=======================================
  Coverage   38.01%   38.01%           
=======================================
  Files         328      328           
  Lines       48328    48328           
=======================================
  Hits        18370    18370           
  Misses      27319    27319           
  Partials     2639     2639
Impacted Files Coverage Δ
models/issue_mail.go 12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8917d66...ac6b7e7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2019
adelowo
adelowo reviewed Jan 29, 2019
View reviewed changes
models/issue_mail.go Outdated Show resolved Hide resolved
@zeripath
Ensure issue.Poster is loaded in mailIssueCommentToParticipants
be41436 
Previous code could potentially dereference nil - this PR ensures
that the poster is loaded before dereferencing it.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath force-pushed the check-poster-is-set-in-mail-comments branch from ac6b7e7 to be41436 Compare January 29, 2019 19:52
@zeripath zeripath mentioned this pull request Jan 29, 2019
Merged
@zeripath
Copy link
Contributor Author

@adelowo is my change ok? (I really think we need to get this approved quickly and before we release v1.7.1 as every person who is on 1.7 and has ENABLE_NOTIFY_MAIL set to true will be experiencing server 500s.)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2019
@zeripath zeripath mentioned this pull request Jan 29, 2019
Closed
7 tasks
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2019
@techknowlogick techknowlogick merged commit 036964b into go-gitea:master Jan 29, 2019
zeripath added a commit to zeripath/gitea that referenced this pull request Jan 29, 2019
@zeripath
Ensure issue.Poster is loaded in mailIssueCommentToParticipants (go-g…
a09ae7b 
…itea#5891)

Previous code could potentially dereference nil - this PR ensures
that the poster is loaded before dereferencing it.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor Author

Of course I then rebase and run my magical #5893 on it and notice another dereference bug...

The repo needs to be loaded too in v1.7 that is. I'll put the fix in to the backport and open another one on master - which is I think protected by these things being loaded higher up but we should ensure that they're there at this level I think.

@zeripath zeripath added the backport/done All backports for this PR have been created label Jan 29, 2019
@adelowo adelowo mentioned this pull request Jan 29, 2019
Merged
@zeripath zeripath mentioned this pull request Jan 29, 2019
Merged
zeripath added a commit that referenced this pull request Jan 29, 2019
@zeripath
Prevent nil dereference in mailIssueCommentToParticipants (#5891, #5895…
0190d3c 
…) (#5894)

* Ensure issue.Poster is loaded in mailIssueCommentToParticipants (#5891)

Previous code could potentially dereference nil - this PR ensures
that the poster is loaded before dereferencing it.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Also ensure the repo is loaded

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath deleted the check-poster-is-set-in-mail-comments branch January 29, 2019 23:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @techknowlogick @adelowo @GiteaBot