Disable redirect for i18n

[techknowlogick]

As title

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@98feb0e). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5910   +/-   ##
=========================================
  Coverage          ?   37.97%           
=========================================
  Files             ?      329           
  Lines             ?    48405           
  Branches          ?        0           
=========================================
  Hits              ?    18382           
  Misses            ?    27383           
  Partials          ?     2640

Impacted Files	Coverage Δ
routers/routes/routes.go	85.12% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98feb0e...6adb4f3. Read the comment docs.

[lunny]

Why change that to false?

[zeripath]

So there's another option, which would mitigate other similar issues in future of sticking a handler before the the il8n handler which does a path.Clean() and redirects to the clean path if the path wasn't clean to begin with.

However this does solve the current problem, and it's not as if the lang query parameter can be used elsewhere - so I'm gonna approve.

[lafriks]

I don't think this is correct solution, we should do fix to upstream lib or move that middleware to gitea code

[lunny]

@lafriks I think this is a temporary PR so that is able to be back port to release/v1.7

[lafriks]

But this does not fix problem completely, problem that currently is solved could be solved also keeping redirect by changing few lines up AppSubURL to AppURL

[techknowlogick]

@lafriks that doesn't entirely work, as i18n library uses AppSubURL to set cookie path

Set-Cookie: lang=fr-FR; Path=/http://localhost:3000; Max-Age=2147483647

[lafriks]

That's shity :D

[techknowlogick]

@lafriks 😂 yup.