Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Dashboard tweaks #5974

Merged
merged 1 commit into from
Feb 6, 2019
Merged

UI: Dashboard tweaks #5974

merged 1 commit into from
Feb 6, 2019

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 6, 2019 •
edited
Loading

  • Don't show divider below heatmap when it's hidden via media-query
  • Make divider below user menu adhere to container width
  • Remove excessive margins on heatmap

Before

screenshot 2019-02-06 at 07 19 25

After

screenshot 2019-02-06 at 07 16 39

@silverwind
UI: Dashboard tweaks
bb854a1 
- Don't show divider below heatmap when it's hidden via media-query
- Make divider between user menu adhere to container width
- Remove excessiv margins on heatmap
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 6, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #5974 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5974      +/-   ##
==========================================
- Coverage   38.71%   38.71%   -0.01%     
==========================================
  Files         330      330              
  Lines       48697    48697              
==========================================
- Hits        18855    18853       -2     
- Misses      27112    27115       +3     
+ Partials     2730     2729       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f286a5a...bb854a1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2019
@zeripath zeripath merged commit 0c721fe into go-gitea:master Feb 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @codecov-io @lafriks @zeripath @techknowlogick @GiteaBot