Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines #5976

Merged
merged 3 commits into from
Feb 7, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 6, 2019

No description provided.

@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 6, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 6, 2019
Copy link

@Nubston Nubston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't quite know what lunny meant by making PR to remove dependent on ssh-keygen but i need this fix here that they have done to use the internal ssh server since i get ssh-keygen error on 1.7.1 when trying to use internal server

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2019
@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #5976 into master will increase coverage by <.01%.
The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5976      +/-   ##
=========================================
+ Coverage    38.7%   38.7%   +<.01%     
=========================================
  Files         330     330              
  Lines       48857   48884      +27     
=========================================
+ Hits        18910   18922      +12     
- Misses      27207   27217      +10     
- Partials     2740    2745       +5
Impacted Files Coverage Δ
modules/ssh/ssh.go 55.48% <44.82%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a1739...9fd05a8. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2019
@techknowlogick techknowlogick merged commit 2d213b6 into go-gitea:master Feb 7, 2019
@lunny lunny deleted the lunny/gen_key branch February 7, 2019 07:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants