Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - #3031 - search for org repos #5986

Merged

Conversation

richmahn
Copy link
Contributor

@richmahn richmahn commented Feb 6, 2019

Adds the search form to the Org home page like it is for the User home page to search and sort repos of the Org. Addresses #3031

Credit goes to @techknowlogick who made most all these edits in the closed PR #3081. Only updates I made were for the new sort options and new way to handle errors.

To test:
Check out branch, generate build, run gitea web, make a new org in your instance of Gitea and add multiple repos, staring and forking some of them. Then use the Search and Sort form on the Org home page.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #5986 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5986      +/-   ##
==========================================
- Coverage   38.77%   38.73%   -0.04%     
==========================================
  Files         332      332              
  Lines       48942    48992      +50     
==========================================
  Hits        18975    18975              
- Misses      27220    27269      +49     
- Partials     2747     2748       +1
Impacted Files Coverage Δ
models/org.go 68.61% <0%> (-0.7%) ⬇️
routers/user/home.go 36.6% <0%> (-4.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb09f0...3cb7c0d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2019
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Feb 6, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 6, 2019
@techknowlogick
Copy link
Member

Thanks for working on this 😄

I'd give this code 5/5 ⭐️s, however since I was involved in this I'll abstain from reviewing.

routers/user/home.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Feb 7, 2019

@richmahn thanks for your PR. Could you give some screenshots?

@richmahn
Copy link
Contributor Author

richmahn commented Feb 7, 2019

@lunny Screenshots:

Org home page without any search and default sort of recently updated
screen shot 2019-02-07 at 6 06 28 am

Org home search for fr_ with default sorting of recently updated
screen shot 2019-02-07 at 6 05 32 am

Org home search for fr_ with sort of most forks
screen shot 2019-02-07 at 6 05 49 am

Org home search for fr_ with sort of most stars
screen shot 2019-02-07 at 6 06 06 am

@richmahn
Copy link
Contributor Author

richmahn commented Feb 7, 2019

Ok, ready to merge (fixed the retaining of the sort order when changing the search query)

@richmahn richmahn changed the title Feature - #3031 - search for org repos [WIP] Feature - #3031 - search for org repos Feb 7, 2019
@richmahn richmahn changed the title [WIP] Feature - #3031 - search for org repos Feature - #3031 - search for org repos Feb 7, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2019
@techknowlogick techknowlogick merged commit ba91214 into go-gitea:master Feb 8, 2019
richmahn added a commit to richmahn/gitea that referenced this pull request Apr 11, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants