Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make organization dropdown scrollable when using mouse wheel #5988

Merged
merged 13 commits into from
Mar 5, 2019
Merged

Make organization dropdown scrollable when using mouse wheel #5988

merged 13 commits into from
Mar 5, 2019

Conversation

metiftikci
Copy link
Contributor

@metiftikci metiftikci commented Feb 7, 2019 •
edited by techknowlogick
Loading

Old:
ddlold

New:
ddlnew

Fix #5580

@lunny lunny added the type/bug label Feb 7, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 7, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 7, 2019
lafriks
lafriks requested changes Feb 7, 2019
View reviewed changes
templates/user/dashboard/navbar.tmpl Outdated
@@ -11,7 +11,7 @@
<div class="ui header">
{{.i18n.Tr "home.switch_dashboard_context"}}
</div>
<div class="items">
<div class="scrolling menu" style="border-radius: 0px !important;box-shadow: none !important;border-bottom: 1px solid rgba(34, 36, 38, 0.15);">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline style should be moved to less/CSS class

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeripath no need to be sorry. This is why there is a policy to have at least two acceptance as sometimes one person may miss something that another doesn't (and vice versa).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lafriks can you check please sir

@lunny
Copy link
Member

lunny commented Feb 25, 2019

conflicted

@codecov-io
Copy link

codecov-io commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #5988 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5988      +/-   ##
==========================================
+ Coverage   38.84%   38.84%   +<.01%     
==========================================
  Files         355      355              
  Lines       50243    50243              
==========================================
+ Hits        19516    19518       +2     
+ Misses      27899    27896       -3     
- Partials     2828     2829       +1
Impacted Files Coverage Δ
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f066bd2...ea6f34b. Read the comment docs.

@metiftikci
Copy link
Contributor Author

metiftikci commented Feb 26, 2019 •
edited
Loading

@lunny conflict resolved

@metiftikci
Copy link
Contributor Author

@lafriks can you review pls

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2019
@techknowlogick techknowlogick changed the title Fix #5580 Make organization dropdown scrollable when using mouse wheel Mar 5, 2019
@techknowlogick techknowlogick merged commit 4512634 into go-gitea:master Mar 5, 2019
@techknowlogick
Copy link
Member

@muhammedtiftikci thanks for PR. Now that this has been merged could you send a backport to the release/v1.7 branch? If you need assistance please feel free to ask, and we can help 😄

@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 12, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Organization dropdown not scrollable when using mouse wheel
7 participants
@metiftikci @lunny @codecov-io @techknowlogick @lafriks @zeripath @GiteaBot