-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to close issues via commit on a non master branch #5992
Merged
lafriks
merged 11 commits into
go-gitea:master
from
adelowo:add_option_to_close_issues_via_commit_on_a_non_master_branch
Feb 10, 2019
Merged
Add option to close issues via commit on a non master branch #5992
lafriks
merged 11 commits into
go-gitea:master
from
adelowo:add_option_to_close_issues_via_commit_on_a_non_master_branch
Feb 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5992 +/- ##
==========================================
+ Coverage 38.72% 38.72% +<.01%
==========================================
Files 338 339 +1
Lines 48994 49013 +19
==========================================
+ Hits 18971 18980 +9
- Misses 27276 27286 +10
Partials 2747 2747
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 7, 2019
zeripath
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 7, 2019
lafriks
reviewed
Feb 7, 2019
…nstance Also note that the config value can still be set so as to be able to control the value for new repositories that are to be created - fix copy/paste error in copyright header year and rearrange import - use repo config instead of server config value to determine if a commit should close an issue - update testsuite
adelowo
force-pushed
the
add_option_to_close_issues_via_commit_on_a_non_master_branch
branch
from
February 9, 2019 11:45
6b6df75
to
98b92a1
Compare
lafriks
reviewed
Feb 9, 2019
lafriks
approved these changes
Feb 10, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 10, 2019
CI passes now :) |
adelowo
deleted the
add_option_to_close_issues_via_commit_on_a_non_master_branch
branch
February 10, 2019 20:18
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. #5622 introduced a breaking change. This adds an option to configure the behavior
of that PR.
Fixes #5957