Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Make dashboard navbar and footer full-width #6013

Merged
merged 4 commits into from
Feb 9, 2019

Conversation

silverwind
Copy link
Member

As @lunny suggested, make the dashboard navbar full-width as well.

Before

screenshot 2019-02-09 at 07 38 47

After

screenshot 2019-02-09 at 07 39 32

@codecov-io
Copy link

codecov-io commented Feb 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3a33742). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6013   +/-   ##
=========================================
  Coverage          ?   38.73%           
=========================================
  Files             ?      332           
  Lines             ?    48992           
  Branches          ?        0           
=========================================
  Hits              ?    18975           
  Misses            ?    27269           
  Partials          ?     2748

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a33742...c49d150. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2019
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 9, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 9, 2019
@lunny
Copy link
Member

lunny commented Feb 9, 2019

@silverwind thanks! Any chance to let all the pages full-width?

@silverwind
Copy link
Member Author

Possible, but each page will need individual care because some of them don't look too good at full width, especially on smaller zoom levels, so we have to do individual fixes. I plan on starting with the dashboard later.

@silverwind silverwind changed the title UI: Make dashboard navbar full-width UI: Make dashboard navbar and footer full-width Feb 9, 2019
@silverwind
Copy link
Member Author

Few more tweaks pushed. The page footer is now also full-width:

screenshot 2019-02-09 at 11 33 56

@silverwind
Copy link
Member Author

silverwind commented Feb 9, 2019

One more tweak related to the footer. On small pages, there were unneccessary scrollbars because the page layout was 100% + 1px high with that 1px coming from the footer border. For some reason I had to add one more pixel to prevent the scrollbar from appearing. Maybe refactor to flexbox later.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2019
@zeripath zeripath merged commit 681345d into go-gitea:master Feb 9, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants