-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and expand information about building Gitea #6019
Conversation
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #6019 +/- ##
==========================================
- Coverage 38.87% 38.86% -0.01%
==========================================
Files 345 345
Lines 49491 49491
==========================================
- Hits 19239 19237 -2
- Misses 27471 27473 +2
Partials 2781 2781
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, some small nits though.
Could you also add a note about adding new config options to the docs? (mainly where to put them)
Signed-off-by: Andrew Thornton <art27@cantab.net>
I've made some changes to hacking: I've added information about adding settings. (Albeit perhaps a little cursory as I note that @lunny has a current PR open to refactor I've added a note to say you will need make (I thought I had put that in already. oops) I've put a bit more detail in about swagger and go-swagger. |
Adjusted the clarifying note about automatic build dependencies. I have avoided mentioning vendor so far because I expect that could be quite complex. We would likely need to talk about dep ensure, make test-vendor and gopkg.toml. There is in general a lack of documentation about hacking on the UI too. This could be done as another pr. |
Vendoring and GOPATH will also change when we migrate to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs!! 🎊
A few nits, but otherwise looks fantastic!
Signed-off-by: Andrew Thornton <art27@cantab.net>
Add in information about postcss
I just noticed that we'd added postcss so added a little thing about that. I think it's probably ready to merge now. |
Thanks peeps. Hopefully people will find this helpful. I guess we just need to try to keep it up to date. I'll pop a comment on @typeless go module pr to suggest that a bit of information to hacking and install is put down. |
The current information on gitea.io for building and hacking on is inadequate. This PR expands on this and provides some more information.
Signed-off-by: Andrew Thornton art27@cantab.net