Fix prohibit login check on authorization #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6106 +/- ##
==========================================
- Coverage 38.88% 38.86% -0.03%
==========================================
Files 349 349
Lines 49755 49801 +46
==========================================
+ Hits 19349 19355 +6
- Misses 27611 27646 +35
- Partials 2795 2800 +5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
requested changes
Feb 18, 2019
models/login_source.go
Outdated
| @@ -642,6 +642,12 @@ func UserSignIn(username, password string) (*User, error) { | |||
| } | |||
|
|
|||
| if hasUser { | |||
| if !user.IsActive { | |||
There was a problem hiding this comment.
This should be checked only after username&password is validated otherwise usernames can be leaked/guessed from private servers
|
Oh, and also |
|
@lafriks done. |
lafriks
approved these changes
Feb 18, 2019
GiteaBot
added
lgtm/need 1
| @@ -113,6 +113,6 @@ func TestCreateReleasePaging(t *testing.T) { | |||
| checkLatestReleaseAndCount(t, session, "/user2/repo1", "v0.0.12", i18n.Tr("en", "repo.release.draft"), 10) | |||
|
|
|||
| // Check that user3 does not see draft and still see 10 latest releases | |||
| session2 := loginUser(t, "user3") | |||
| session2 := loginUser(t, "user4") | |||
There was a problem hiding this comment.
Please change comment above to reference user4
techknowlogick
approved these changes
Feb 19, 2019
GiteaBot
added
lgtm/done
lunny
force-pushed
the
lunny/fix_bug_prohibit_login
branch
from
925c303
to
9927680
Compare
lafriks
changed the title
|
@lunny please backport |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 19, 2019
* fix bug prohibit login not applied on dashboard * fix tests * fix bug user status leak * fix typo * return after render
lafriks
pushed a commit
that referenced
this pull request
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, a prohibit login account also can login and see the dashboard page. This PR will add more checks to fix that.