Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor issue indexer, add some testing and fix a bug #6131

Merged
merged 4 commits into from
Feb 21, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 20, 2019

This PR is a further work of #5363. It moved all issue indexer codes from models to modules/indexer/issues, added some unit tests and fix a bug caused by #5363.

@lunny lunny added type/bug type/testing type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Feb 20, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 20, 2019
@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #6131 into master will decrease coverage by 0.01%.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6131      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.02%     
==========================================
  Files         352      352              
  Lines       50045    50049       +4     
==========================================
- Hits        19447    19441       -6     
- Misses      27782    27793      +11     
+ Partials     2816     2815       -1
Impacted Files Coverage Δ
models/unit_tests.go 72.8% <ø> (+1.86%) ⬆️
models/issue.go 47.59% <0%> (-0.08%) ⬇️
routers/api/v1/repo/issue.go 23.46% <0%> (ø) ⬆️
routers/init.go 68.49% <0%> (ø) ⬆️
routers/repo/issue.go 36.42% <100%> (ø) ⬆️
modules/notification/indexer/indexer.go 56.6% <62.5%> (ø) ⬆️
modules/indexer/issues/indexer.go 62.74% <62.74%> (ø)
modules/indexer/issues/queue_disk.go 49.18% <66.66%> (-3.37%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 44.54% <0%> (-1.15%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf9ded...3dfcd7c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2019
routers/init.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2019
@lunny lunny merged commit 0751153 into go-gitea:master Feb 21, 2019
@lunny lunny deleted the lunny/refactor_issue_indexer2 branch February 21, 2019 00:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants