Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split setting.go to multiple files #6154

Merged
merged 9 commits into from
Mar 16, 2019
Merged

split setting.go to multiple files #6154

merged 9 commits into from
Mar 16, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 22, 2019

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 22, 2019
@codecov-io
Copy link

codecov-io commented Mar 1, 2019 •
edited
Loading

Codecov Report

Merging #6154 into master will increase coverage by 0.02%.
The diff coverage is 38.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6154      +/-   ##
==========================================
+ Coverage   38.85%   38.88%   +0.02%     
==========================================
  Files         359      363       +4     
  Lines       51191    51210      +19     
==========================================
+ Hits        19892    19912      +20     
+ Misses      28432    28429       -3     
- Partials     2867     2869       +2
Impacted Files Coverage Δ
modules/setting/setting.go 48.07% <100%> (+2.51%) ⬆️
modules/setting/cron.go 25% <25%> (ø)
modules/setting/repository.go 51.42% <51.42%> (ø)
modules/setting/git.go 57.14% <57.14%> (ø)
modules/setting/markup.go 6.89% <6.89%> (ø)
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf446b...cc2297c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2019
@lunny lunny added this to the 1.8.0 milestone Mar 1, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2019
@lunny lunny merged commit 3792896 into go-gitea:master Mar 16, 2019
@lunny lunny deleted the lunny/refactor_setting branch March 16, 2019 03:12
@lunny
Copy link
Member Author

lunny commented Jun 13, 2019

partially fix #3917

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BetaCat0 BetaCat0 BetaCat0 approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @BetaCat0 @adelowo @GiteaBot @techknowlogick