Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when set indexer as db and add tests #6173

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 24, 2019

caused by #6144

@lunny lunny added this to the 1.8.0 milestone Feb 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #6173 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6173      +/-   ##
==========================================
+ Coverage   38.83%   38.88%   +0.05%     
==========================================
  Files         354      354              
  Lines       50183    50184       +1     
==========================================
+ Hits        19490    19516      +26     
+ Misses      27868    27842      -26     
- Partials     2825     2826       +1
Impacted Files Coverage Δ
modules/indexer/issues/indexer.go 65.45% <100%> (+5.82%) ⬆️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️
modules/indexer/issues/db.go 59.09% <0%> (+59.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0514376...00fc2fb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2019
@techknowlogick techknowlogick merged commit 15ecc08 into go-gitea:master Feb 24, 2019
@lunny lunny deleted the lunny/fix_bug_dummy_queue branch February 25, 2019 01:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants