Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go 1.12 for tests and deprecate go 1.9 #6186

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Use go 1.12 for tests and deprecate go 1.9 #6186

merged 4 commits into from
Feb 26, 2019

Conversation

techknowlogick
Copy link
Member

Blocked until 1.12 docker images are released

@techknowlogick techknowlogick added status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Feb 26, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 26, 2019
kolaente
kolaente reviewed Feb 26, 2019
View reviewed changes
.drone.yml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2019
@techknowlogick
Copy link
Member Author

Waiting on docker-library/golang#264 to be merged

sapk
sapk approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need to wait for the docker image.

Just to be sure I checked that you are also ready to update the xgo image 😄
techknowlogick/xgo#2

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2019
@techknowlogick
Copy link
Member Author

@sapk yes, I will merge the xgo PR after we release 1.7.3, but before 1.8.0. Thanks for review 😃

@techknowlogick
Copy link
Member Author

Now awaiting docker-library/official-images#5473

@techknowlogick techknowlogick removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Feb 26, 2019
@techknowlogick
Fix duplicated step names
44fdf42 
(in preperation for drone 1.0.0)
@techknowlogick
Copy link
Member Author

No longer blocked. golang v1.12 image released.

I've also added updates to remove some duplicated step names, as this would block a move to drone 1.0.0 if not done.

@codecov-io
Copy link

Codecov Report

Merging #6186 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6186      +/-   ##
==========================================
- Coverage   38.88%   38.87%   -0.02%     
==========================================
  Files         354      354              
  Lines       50192    50192              
==========================================
- Hits        19516    19510       -6     
- Misses      27850    27857       +7     
+ Partials     2826     2825       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7afe81f...44fdf42. Read the comment docs.

@zeripath
Copy link
Contributor

Make lg-tm work

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2019
@appleboy appleboy merged commit 1142632 into go-gitea:master Feb 26, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch April 21, 2019 03:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente left review comments

@appleboy appleboy appleboy approved these changes

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@techknowlogick @codecov-io @zeripath @appleboy @sapk @kolaente @GiteaBot