Skip to content

Add unit types to repo action URL to correctly show 404 when archived #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 9, 2019
Merged

Add unit types to repo action URL to correctly show 404 when archived #6247

merged 8 commits into from
Mar 9, 2019

Conversation

jolheiser
Copy link
Member

Fixes #6228

@jolheiser
Add unit types to repo action URL to correctly show 404 when archived
0900692 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@codecov-io
Copy link

codecov-io commented Mar 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f7ffb19). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6247   +/-   ##
=========================================
  Coverage          ?   38.89%           
=========================================
  Files             ?      359           
  Lines             ?    50993           
  Branches          ?        0           
=========================================
  Hits              ?    19835           
  Misses            ?    28288           
  Partials          ?     2870
Impacted Files Coverage Δ
routers/routes/routes.go 83.05% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ffb19...7530ecd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2019
@adelowo
Copy link
Member

adelowo commented Mar 7, 2019

Can this be tagged as a bug and make it into 1.8 since repo archival( #5009 ) too is in 1.8?

@techknowlogick techknowlogick added this to the 1.8.0 milestone Mar 7, 2019
@techknowlogick
Copy link
Member

@adelowo tagged

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2019
@zeripath zeripath merged commit 8211e01 into go-gitea:master Mar 9, 2019
@jolheiser jolheiser deleted the 6228_archived_repo_action branch March 14, 2019 16:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Add star in archived repo results in an error
7 participants
@jolheiser @codecov-io @adelowo @techknowlogick @lunny @zeripath @GiteaBot