Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use url.PathEscape to escape the branchname #6304

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

zeripath
Copy link
Contributor

It is currently not possible to push a branch containing a % in it's name as it causes the internal protected branch checking api to return an error.

This code protects the branchname with url.PathEscape

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #6304 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6304      +/-   ##
==========================================
- Coverage   38.82%   38.81%   -0.01%     
==========================================
  Files         359      359              
  Lines       51100    51100              
==========================================
- Hits        19838    19836       -2     
- Misses      28391    28393       +2     
  Partials     2871     2871
Impacted Files Coverage Δ
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50631b5...df8b2ed. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2019
@lafriks lafriks added this to the 1.8.0 milestone Mar 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2019
@lafriks lafriks merged commit 663874e into go-gitea:master Mar 11, 2019
@zeripath zeripath deleted the fix-push-branch-with-percent branch March 13, 2019 09:55
@jeblair jeblair mentioned this pull request Mar 26, 2019
3 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants