Return 409 when creating repo if it already exists.

[bogdanpetrea]

fixes #6329

[lafriks]

Moving this to 1.8 as this is more big thant enhancement

[bogdanpetrea]

It seems that currently the tests fail with a 500 error, because of an uncaught UNIQUE constraint failed: repository.owner_id, repository.lower_name error. Any clue on why it isn't transformed into a ErrRepoAlreadyExist?

[zeripath]

This is likely happening because user id 2's repo2 doesn't actually exist on the filesystem.

If you look at isRepositoryExist():

https://github.com/go-gitea/gitea/blob/master/models/repo.go#L1284

It checks whether the repo is actually extant on the system, and I suspect that repo2 is one of the original test-fixtures so won't have a filesystem representation.

[bogdanpetrea]

Thanks for clarifying @zeripath!
Maybe isRepositoryExist could be split into a function with a similar name that checks if the model exists and another isRepositoryReady or similar, that checks if the repo is present on the filesystem. In this way there would be a clear distinction between the 2 situations and the error could be handled better.

[zeripath]

I agree.

[zeripath]

Anyway in this case you should just change your test to actually attempt to create the same repo twice rather than rely on an already "created" repo.

If the provided test environment is too simple for that - copy the style in test_git.go

[codecov-io]

Codecov Report

Merging #6330 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #6330      +/-   ##
==========================================
+ Coverage   38.83%   38.86%   +0.03%     
==========================================
  Files         359      359              
  Lines       51182    51183       +1     
==========================================
+ Hits        19875    19892      +17     
+ Misses      28437    28424      -13     
+ Partials     2870     2867       -3

Impacted Files	Coverage Δ
routers/api/v1/repo/repo.go	57.08% <66.66%> (+1.7%)	⬆️
models/repo.go	47.44% <0%> (+0.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7780ea8...6acc1bb. Read the comment docs.