-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable benchmarking during tag events on DroneIO #6365
Disable benchmarking during tag events on DroneIO #6365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6365 +/- ##
==========================================
+ Coverage 38.86% 38.87% +0.01%
==========================================
Files 365 365
Lines 51341 51341
==========================================
+ Hits 19953 19960 +7
+ Misses 28516 28510 -6
+ Partials 2872 2871 -1
Continue to review full report at Codecov.
|
@techknowlogick why ? does it failed during CI ? Because the goal was mainly to keep track of performance between releases. |
@sapk yes, it fails on the migrate benchmark. I think we should wait until we migrate to Drone 1.0.0 to resolve this so we can have a separate benchmark pipeline and have that run on a dedicated machine as well. |
Create an issue for that is better so that we will not forget that. |
As title, will need to be backported to release/v1.8
(When this gets backported 1.8.0-rc1 can be retagged)