Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Make sure units of a team are returned #6379

Merged
merged 2 commits into from
Mar 19, 2019
Merged

api: Make sure units of a team are returned #6379

merged 2 commits into from
Mar 19, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Mar 19, 2019

Fixes #6354

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 19, 2019
@techknowlogick techknowlogick added type/bug modifies/api This PR adds API routes or modifies them labels Mar 19, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Mar 19, 2019
@adelowo adelowo changed the title Make sure units of a team are returned api: Make sure units of a team are returned Mar 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2019
@adelowo
Copy link
Member Author

adelowo commented Mar 19, 2019

Will this pass for a backport to 1.8 ?

@techknowlogick
Copy link
Member

@adelowo good thinking. I’ve just added the label.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@359d3ed). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6379   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      365           
  Lines             ?    51346           
  Branches          ?        0           
=========================================
  Hits              ?    19960           
  Misses            ?    28514           
  Partials          ?     2872
Impacted Files Coverage Δ
routers/api/v1/org/team.go 3.99% <0%> (ø)
models/org_team.go 50.58% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359d3ed...f15580c. Read the comment docs.

@techknowlogick techknowlogick merged commit 5c82ef0 into go-gitea:master Mar 19, 2019
@techknowlogick
Copy link
Member

@adelowo please backport :)

@adelowo adelowo deleted the make_sure_units_are_returned branch March 19, 2019 21:54
adelowo added a commit to adelowo/gitea that referenced this pull request Mar 19, 2019
@adelowo
make sure units of a team are returned (go-gitea#6379)
3fa54bd
@adelowo adelowo mentioned this pull request Mar 19, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Mar 19, 2019
@adelowo @techknowlogick
make sure units of a team are returned (#6379) (#6381)
1681530
@lafriks lafriks added the backport/done All backports for this PR have been created label Mar 25, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

[API] Org teams api does not return units
7 participants
@adelowo @techknowlogick @codecov-io @zeripath @jolheiser @lafriks @GiteaBot