Prevent server 500 on compare branches with no common history (#6555) #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ea#6555) * Prevent 500 if there is no common mergebase * Prevent creation of PR with no history
jolheiser
approved these changes
Apr 9, 2019
GiteaBot
added
the
lgtm/need 1
|
Fixes #6527 and probably others. |
mrsdizzie
approved these changes
Apr 9, 2019
|
Ah damn! This PR changes the code in the old git project! |
adelowo
approved these changes
Apr 10, 2019
GiteaBot
added
lgtm/done
|
CI failed. |
|
Yeah we would need to resurrect the old git subproject, change it, update the Gitea 1.8 branch to use these changes and then try again. I can probably make PRs for this this evening UK time if it's wanted - but the git project needs to be resurrected for me to put a pr against. |
|
make LG-TM work? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6555 to release/v1.8