Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API OTP Context #6674

Merged
merged 11 commits into from
Apr 19, 2019
Merged

API OTP Context #6674

merged 11 commits into from
Apr 19, 2019

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 18, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 18, 2019
@techknowlogick techknowlogick requested review from zeripath and a team April 18, 2019 22:16
@techknowlogick techknowlogick requested a review from a team April 18, 2019 22:40
@codecov-io
Copy link

codecov-io commented Apr 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@dae94e3). Click here to learn what that means.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6674   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      415           
  Lines             ?    56382           
  Branches          ?        0           
=========================================
  Hits              ?    23338           
  Misses            ?    29913           
  Partials          ?     3131
Impacted Files Coverage Δ
modules/context/auth.go 20.22% <0%> (ø)
modules/auth/auth.go 49.6% <0%> (ø)
routers/api/v1/api.go 75.31% <25%> (ø)
modules/context/api.go 48.48% <38.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae94e3...6772540. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2019
jolheiser
jolheiser reviewed Apr 19, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just needs the discussed changes from Discord. 👍

jolheiser
jolheiser requested changes Apr 19, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

modules/context/auth.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2019
jolheiser
jolheiser requested changes Apr 19, 2019
View reviewed changes
routers/api/v1/api.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2019
@lafriks lafriks merged commit 19ec260 into go-gitea:master Apr 19, 2019
@techknowlogick techknowlogick mentioned this pull request Apr 19, 2019
Merged
lunny pushed a commit that referenced this pull request Apr 19, 2019
@techknowlogick @lunny
backport #6674 - API OTP Context (#6676)
ba12463
@techknowlogick techknowlogick deleted the api-2fa branch April 21, 2019 03:01
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @codecov-io @lafriks @zeripath @jolheiser @GiteaBot