-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix 6778 #6794
[WIP] Fix 6778 #6794
Conversation
sapk
commented
Apr 29, 2019
•
edited
Loading
edited
- Add test to reproduce the bug
- Fix GPG not using correct UID #6778
The lib we use shouldn't return revoked ident but in this case it does. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
@6543 the test is in the unit tests. And it is the one that failed. I haven't time to do so and only just quickly look at the code failing. but from time to time I update the lib to find if it fixed it 🤞 😄 . |
Also we should maybe create a new key without user information. (I think it is order dependant) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
@sapk can you update :) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
is it fixed upstream? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
we should update after #12481 got merged |
ok @sapk can you update to test? |
Are we sure it's still needed? |
#6778 is still open so I guess |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
update? |