Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the v78 migration "Drop is_bare" on MSSQL #6707 #6823

Merged
merged 5 commits into from
May 5, 2019
Merged

Fix the v78 migration "Drop is_bare" on MSSQL #6707 #6823

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b849c3
Attempt to fix #6707
zeripath May 1, 2019
83d5ade
Merge branch 'master' into fix-#6707-drop-is-bare-mssql
zeripath May 5, 2019
21ccbdf
Merge branch 'master' into fix-#6707-drop-is-bare-mssql
zeripath May 5, 2019
7fdbd9a
Merge branch 'master' into fix-#6707-drop-is-bare-mssql
zeripath May 5, 2019
0e89c08
Merge branch 'master' into fix-#6707-drop-is-bare-mssql
techknowlogick May 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion models/migrations/v78.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,14 @@ func renameRepoIsBareToIsEmpty(x *xorm.Engine) error {
if models.DbCfg.Type == core.POSTGRES || models.DbCfg.Type == core.SQLITE {
_, err = sess.Exec("DROP INDEX IF EXISTS IDX_repository_is_bare")
} else if models.DbCfg.Type == core.MSSQL {
_, err = sess.Exec("DROP INDEX IF EXISTS IDX_repository_is_bare ON repository")
_, err = sess.Exec(`DECLARE @ConstraintName VARCHAR(256)
DECLARE @SQL NVARCHAR(256)
SELECT @ConstraintName = obj.name FROM sys.columns col LEFT OUTER JOIN sys.objects obj ON obj.object_id = col.default_object_id AND obj.type = 'D' WHERE col.object_id = OBJECT_ID('repository') AND obj.name IS NOT NULL AND col.name = 'is_bare'
SET @SQL = N'ALTER TABLE [repository] DROP CONSTRAINT [' + @ConstraintName + N']'
EXEC sp_executesql @SQL`)
if err != nil {
return err
}
} else if models.DbCfg.Type == core.MYSQL {
indexes, err := sess.QueryString(`SHOW INDEX FROM repository WHERE KEY_NAME = 'IDX_repository_is_bare'`)
if err != nil {
Expand Down