Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in PR migration check #7368

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Fix typo in PR migration check #7368

merged 2 commits into from
Jul 6, 2019

Conversation

mrsdizzie
Copy link
Member

Fix typo that somehow wasn't triggered during testing of last PR (sorry!)

@lafriks lafriks added this to the 1.9.0 milestone Jul 6, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 6, 2019
@codecov-io
Copy link

codecov-io commented Jul 6, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@89aa08d). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7368   +/-   ##
=========================================
  Coverage          ?   41.22%           
=========================================
  Files             ?      467           
  Lines             ?    63363           
  Branches          ?        0           
=========================================
  Hits              ?    26122           
  Misses            ?    33826           
  Partials          ?     3415
Impacted Files Coverage Δ
modules/migrations/migrate.go 19.2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89aa08d...603b3ae. Read the comment docs.

@techknowlogick techknowlogick merged commit 7166629 into go-gitea:master Jul 6, 2019
@lunny
Copy link
Member

lunny commented Jul 7, 2019

@mrsdizzie Thanks.

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@mrsdizzie @jeffliu27
Fix typo in PR migration check (go-gitea#7368)
4929797
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mrsdizzie @codecov-io @lunny @techknowlogick @lafriks @GiteaBot