-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typos #7552
Fixed typos #7552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for your contrib and your catch.
The function name is also malformated (golang comments need to start with function name). The function should be renamed and any reference to it also.
Wow, hah, didn't notice that! Will fix. |
Ok, I see: this stems from a typo in go-macaron. Will try to fix this upstream first. Could be interesting as it's a breaking API change. |
For reference: go-macaron/session#29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Methods must be renamed also
@lafriks Yeah, see comments above in this PR. It's a bit of an upstream-induced mess. |
Simple, nit-picky typo fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this won't work. They're part of an external API
Thanks for your attempt but this just won't work unless we either:
|
fix this on our side: https://gitea.com/macaron/session/ ? |
@6543 I think the macaron.Session.Destory ones have been fixed and are in the gitea git. Not sure if the session shim was updated at the same time though. I'll remove my review if you want to bring this PR back to life. |
If so not now |
Yes, this could be closed I think. |
Codecov Report
@@ Coverage Diff @@
## master #7552 +/- ##
=========================================
Coverage ? 41.67%
=========================================
Files ? 529
Lines ? 68542
Branches ? 0
=========================================
Hits ? 28565
Misses ? 36324
Partials ? 3653 Continue to review full report at Codecov.
|
Updating the PR with last changes master seems to pass and the change is void now. This was implemented by https://gitea.com/macaron/session/pulls/7 and #7933 I will close this PR because it has been implemented elsewhere and not needed anymore. Thanks @muesli for the finding and PR. |
Simple, nit-picky typo fixes.