Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos #7552

Closed
wants to merge 2 commits into from
Closed

Fixed typos #7552

wants to merge 2 commits into from

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Jul 21, 2019

Simple, nit-picky typo fixes.

Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contrib and your catch.
The function name is also malformated (golang comments need to start with function name). The function should be renamed and any reference to it also.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2019
@muesli
Copy link
Contributor Author

muesli commented Jul 21, 2019

Wow, hah, didn't notice that! Will fix.

@muesli
Copy link
Contributor Author

muesli commented Jul 21, 2019

Ok, I see: this stems from a typo in go-macaron. Will try to fix this upstream first. Could be interesting as it's a breaking API change.

@muesli
Copy link
Contributor Author

muesli commented Jul 21, 2019

For reference: go-macaron/session#29

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2019
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods must be renamed also

@muesli
Copy link
Contributor Author

muesli commented Jul 21, 2019

@lafriks Yeah, see comments above in this PR. It's a bit of an upstream-induced mess.

Simple, nit-picky typo fixes.
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this won't work. They're part of an external API

@zeripath
Copy link
Contributor

Thanks for your attempt but this just won't work unless we either:

  • Get upstream fixed (unlikely as there's been a pr proposing this fix for years)
  • Fork upstream, bring in-house and fix ourselves - in which case we can remove these files and fix the session provider directly
  • Migrate to some other session provider

@zeripath zeripath added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jul 24, 2019
@6543
Copy link
Member

6543 commented Oct 21, 2019

fix this on our side: https://gitea.com/macaron/session/ ?

@zeripath
Copy link
Contributor

@6543 I think the macaron.Session.Destory ones have been fixed and are in the gitea git. Not sure if the session shim was updated at the same time though. I'll remove my review if you want to bring this PR back to life.

@6543
Copy link
Member

6543 commented Oct 21, 2019

If so not now

@lunny
Copy link
Member

lunny commented Oct 21, 2019

Yes, this could be closed I think.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@41c7aa5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7552   +/-   ##
=========================================
  Coverage          ?   41.67%           
=========================================
  Files             ?      529           
  Lines             ?    68542           
  Branches          ?        0           
=========================================
  Hits              ?    28565           
  Misses            ?    36324           
  Partials          ?     3653

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c7aa5...1f7a313. Read the comment docs.

@sapk
Copy link
Member

sapk commented Oct 21, 2019

Updating the PR with last changes master seems to pass and the change is void now.

This was implemented by https://gitea.com/macaron/session/pulls/7 and #7933

I will close this PR because it has been implemented elsewhere and not needed anymore. Thanks @muesli for the finding and PR.

@sapk sapk closed this Oct 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants