Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: fix multiple bugs with statuses endpoints (Backport #7785) #7807

Merged
merged 1 commit into from
Aug 9, 2019
Merged

api: fix multiple bugs with statuses endpoints (Backport #7785) #7807

merged 1 commit into from
Aug 9, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Aug 9, 2019

Backport #7785

@sapk @lafriks
api: fix multiple bugs with statuses endpoints (go-gitea#7785)
c2f5cb5 
* fix commit statuses api url

* search refs before passing sha

* adjust tests

* directly search tags and branches names + remove un-needed check in NewCommitStatus

* fix comment

* de-duplicate code

* test: use relative setting.AppURL

* Update routers/api/v1/repo/status.go

Co-Authored-By: Lauris BH <lauris@nix.lv>

* remove return

* Update routers/api/v1/repo/status.go

Co-Authored-By: Lauris BH <lauris@nix.lv>
@lafriks
Copy link
Member

lafriks commented Aug 9, 2019

Tests seem to fail

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2019
@lafriks lafriks added this to the 1.9.1 milestone Aug 9, 2019
@sapk
Copy link
Member Author

sapk commented Aug 9, 2019

Yes, I had to fix merge issue when cherry-picking and I let a test that wasn't before (and not related to the PR) and doesn't validate. I re-push a new merge in hope that it pass.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 9, 2019
@lafriks lafriks merged commit 38e7997 into go-gitea:release/v1.9 Aug 9, 2019
@sapk sapk deleted the backport-7785 branch August 9, 2019 14:14
@MarkusAmshove MarkusAmshove mentioned this pull request Aug 15, 2019
Closed
4 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sapk @lafriks @lunny @GiteaBot