Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint to v1.17.1 #7848

Merged
merged 12 commits into from
Aug 14, 2019
Merged

Update golangci-lint to v1.17.1 #7848

merged 12 commits into from
Aug 14, 2019

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added this to the 1.10.0 milestone Aug 14, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 14, 2019
@techknowlogick techknowlogick added topic/code-linting lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2019
@lunny
Copy link
Member

lunny commented Aug 14, 2019

CI failed.

@techknowlogick
Copy link
Member Author

@lunny misspell 😢

@techknowlogick
Copy link
Member Author

CI fix done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2019
@techknowlogick techknowlogick merged commit 99a004c into master Aug 14, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch August 14, 2019 03:32
@guillep2k guillep2k mentioned this pull request Aug 22, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@lunny lunny lunny approved these changes

@kolaente kolaente Awaiting requested review from kolaente

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@techknowlogick @lunny @sapk @GiteaBot