Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pull creation with empty changes (#7920) #7926

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix pull creation with empty changes (#7920) #7926

merged 1 commit into from
Aug 21, 2019

Conversation

typeless
Copy link
Contributor

  • Logs the stderr of git-apply
  • Add an integration test
  • Skip testPatch when patch is empty

@typeless
Fix pull creation with empty changes (go-gitea#7920)
7fb6603 
* Logs the stderr of git-apply
* Add an integration test
* Skip testPatch when patch is empty
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 21, 2019
@lunny lunny added this to the 1.9.2 milestone Aug 21, 2019
@typeless typeless mentioned this pull request Aug 21, 2019
Merged
@lunny
Copy link
Member

lunny commented Aug 21, 2019

back port from #7920

@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2019
@techknowlogick techknowlogick merged commit c491c22 into go-gitea:release/v1.9 Aug 21, 2019
aswild added a commit to aswild/gitea that referenced this pull request Aug 25, 2019
@aswild
Merge tag 'v1.9.2' into wild/v1.9
24b10ab 
* BUGFIXES
  * Fix wrong sender when send slack webhook (go-gitea#7918) (go-gitea#7924)
  * Upload support text/plain; charset=utf8 (go-gitea#7899)
  * Lfs/lock: round locked_at timestamp to second (go-gitea#7872) (go-gitea#7875)
  * Fix non existent milestone with 500 error (go-gitea#7867) (go-gitea#7873)
* SECURITY
  * Fix No PGP signature on 1.9.1 tag (go-gitea#7874)
  * Release built with go 1.12.9 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ
* ENHANCEMENT
  * Fix pull creation with empty changes (go-gitea#7920) (go-gitea#7926)
* BUILD
  * Drone/docker: prepare multi-arch release + provide arm64 image (go-gitea#7571) (go-gitea#7884)
@typeless typeless deleted the v1.9/pull-with-empty-changes branch August 28, 2019 06:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.2
Development

Successfully merging this pull request may close these issues.
4 participants
@typeless @lunny @techknowlogick @GiteaBot