Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8369: Create .ssh dir as necessary (#8486) #8489

Merged
merged 3 commits into from
Oct 13, 2019

Conversation

zeripath
Copy link
Contributor

Backport #8486

  • Ensure .ssh dir exists before rewriting public keys

  • Ensure .ssh dir exists before appending to authorized_keys

  • Log the error because it would be useful to know where it is trying to MkdirAll

  • Only try to create RootPath if it's not empty

Fixes #8369

* Ensure .ssh dir exists before rewriting public keys

* Ensure .ssh dir exists before appending to authorized_keys

* Log the error because it would be useful to know where it is trying to MkdirAll

* Only try to create RootPath if it's not empty
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Oct 13, 2019
@zeripath zeripath added this to the 1.9.5 milestone Oct 13, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 13, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 13, 2019
@lafriks lafriks merged commit cb31f88 into go-gitea:release/v1.9 Oct 13, 2019
@zeripath zeripath deleted the backport-8486 branch October 13, 2019 20:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants