Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make call createMilestoneComment on newIssue func #8678

Merged
merged 3 commits into from
Oct 25, 2019
Merged

make call createMilestoneComment on newIssue func #8678

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b8b410
make call createMilestoneComment on newIssue func
metiftikci Oct 24, 2019
59d26aa
make OldMilestoneID 0 instead of -1
metiftikci Oct 24, 2019
afdc5b8
Merge branch 'master' into fix_milestone_comment
lunny Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions models/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,10 @@ func newIssue(e *xorm.Session, doer *User, opts NewIssueOptions) (err error) {
if _, err = e.Exec("UPDATE `milestone` SET num_issues=num_issues+1 WHERE id=?", opts.Issue.MilestoneID); err != nil {
return err
}

if _, err = createMilestoneComment(e, doer, opts.Repo, opts.Issue, -1, opts.Issue.MilestoneID); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've seen this only after I approved. The value for oldMilestoneID must be 0, not -1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made -1 too because old code was

https://github.com/go-gitea/gitea/pull/8221/files#diff-d5eea3b2c0d4c92d62e12b34eb8da2c0L1122

Copy link
Member

@guillep2k guillep2k Oct 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. But when you assign an existing issue to a milestone, the number used for that column is 0. That's an inconsistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

return err
}
}

// Insert the assignees
Expand Down