Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 100% width search bar #8710

Merged
merged 9 commits into from
Oct 29, 2019
Merged

Make 100% width search bar #8710

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0754c9d
Make 100% width search bar
metiftikci Oct 27, 2019
1dca7df
Merge branch 'master' into searchbar
Oct 27, 2019
4f5285d
Merge branch 'master' into searchbar
lunny Oct 28, 2019
1401d66
Use flex: auto instead of flex: 1
metiftikci Oct 28, 2019
57f6f5e
Merge branch 'master' into searchbar
Oct 28, 2019
802e06f
Merge branch 'master' into searchbar
lafriks Oct 28, 2019
46378b9
Merge branch 'master' into searchbar
techknowlogick Oct 28, 2019
3bb8e40
Merge branch 'master' into searchbar
lafriks Oct 28, 2019
669c259
Merge branch 'master' into searchbar
techknowlogick Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,7 @@ i.icon.centerlock{top:1.5em}
.repository .segment.reactions .select-reaction{float:none}
.repository .segment.reactions .select-reaction:not(.active) a{display:none}
.repository .segment.reactions:hover .select-reaction a{display:block}
.repository .ui.fluid.action.input .ui.search.action.input{flex:1}
.user-cards .list{padding:0;display:flex;flex-wrap:wrap}
.user-cards .list .item{list-style:none;width:32%;margin:10px 10px 10px 0;padding-bottom:14px;float:left}
.user-cards .list .item .avatar{width:48px;height:48px;float:left;display:block;margin-right:10px}
Expand Down
6 changes: 6 additions & 0 deletions public/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1936,6 +1936,12 @@
display: block;
}
}

.ui.fluid.action.input {
.ui.search.action.input {
flex: 1;
Copy link
Member

@6543 6543 Oct 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaqra why no use "auto" instead of "1"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex: 1; equals to:

  • flex-grow: 1;
  • flex-shrink: 1;
  • flex-basis: 0;

flex: auto; equals to:

  • flex-grow: 1;
  • flex-shrink: 1;
  • flex-basis: auto;

so in this case both are same but if you want i can change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more redable i think ... thats all :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaqra Yes would be nice for other maintainers ...

}
}
}

// End of .repository
Expand Down