Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move push commits events to notification #8783

Merged
merged 3 commits into from
Nov 3, 2019
Merged

Move push commits events to notification #8783

merged 3 commits into from
Nov 3, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 2, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 2, 2019
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2019
@lunny @guillep2k
Update modules/notification/base/null.go
c167dea 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Nov 3, 2019 •
edited
Loading

Codecov Report

Merging #8783 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8783      +/-   ##
==========================================
+ Coverage   41.25%   41.25%   +<.01%     
==========================================
  Files         542      542              
  Lines       69708    69704       -4     
==========================================
+ Hits        28758    28759       +1     
+ Misses      37269    37267       -2     
+ Partials     3681     3678       -3
Impacted Files Coverage Δ
services/mirror/sync.go 0% <0%> (ø) ⬆️
modules/notification/base/null.go 65.21% <100%> (+1.58%) ⬆️
modules/notification/notification.go 75.51% <100%> (+1.04%) ⬆️
modules/repofiles/action.go 64.33% <100%> (+0.64%) ⬆️
modules/notification/webhook/webhook.go 41.27% <63.15%> (+1.07%) ⬆️
modules/indexer/indexer.go 44.73% <0%> (-10.53%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 37.71% <0%> (-0.88%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7a6d9...3d309f7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2019
@lunny lunny merged commit 022d2d8 into go-gitea:master Nov 3, 2019
@lunny lunny deleted the lunny/move_push_commits_notification branch November 3, 2019 06:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @guillep2k @6543 @GiteaBot