Skip to content

Fix (open/closed) issue count when label excluded #8815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 5, 2019
Merged

Fix (open/closed) issue count when label excluded #8815

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b976a5d
Fix (open/closed) issue count when label excluded
metiftikci Nov 3, 2019
578f6d7
Merge branch 'master' into issue_count
Nov 3, 2019
5c89bce
Use capital sql keywords
Nov 4, 2019
3a833de
Merge branch 'master' into issue_count
Nov 4, 2019
af050ba
Merge branch 'master' into issue_count
Nov 4, 2019
1c02c63
Merge branch 'master' into issue_count
lafriks Nov 4, 2019
d3a3aa5
Merge branch 'master' into issue_count
techknowlogick Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions models/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,8 +1293,12 @@ func GetIssueStats(opts *IssueStatsOptions) (*IssueStats, error) {
log.Warn("Malformed Labels argument: %s", opts.Labels)
} else {
for i, labelID := range labelIDs {
sess.Join("INNER", fmt.Sprintf("issue_label il%d", i),
fmt.Sprintf("issue.id = il%[1]d.issue_id AND il%[1]d.label_id = %[2]d", i, labelID))
if labelID > 0 {
sess.Join("INNER", fmt.Sprintf("issue_label il%d", i),
fmt.Sprintf("issue.id = il%[1]d.issue_id AND il%[1]d.label_id = %[2]d", i, labelID))
} else {
sess.Where("issue.id NOT IN (SELECT issue_id FROM issue_label WHERE label_id = ?)", -labelID)
}
}
}
}
Expand Down