Skip to content

Move code.gitea.io/gitea/routers/api/v1/convert to code.gitea.io/gitea/modules/convert #8892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Nov 10, 2019
Merged

Move code.gitea.io/gitea/routers/api/v1/convert to code.gitea.io/gitea/modules/convert #8892

lunny merged 2 commits into from
Nov 10, 2019

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 9, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 9, 2019
@6543
Copy link
Member

6543 commented Nov 9, 2019

@lunny golangci-lint Error

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 9, 2019
6543
6543 approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside go fmt ;)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2019
@lunny lunny force-pushed the lunny/move_convert branch from 86b45b9 to 2e9beb4 Compare November 10, 2019 01:15
guillep2k
guillep2k approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the lowest review_complexity to file_count ratio that I've ever reviewed. 😄

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2019
@lunny lunny merged commit daab245 into go-gitea:master Nov 10, 2019
@lunny lunny deleted the lunny/move_convert branch November 10, 2019 04:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @6543 @guillep2k @GiteaBot