Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Fixed creating Windows service commands #8979

Merged
merged 3 commits into from
Nov 14, 2019
Merged

fix(docs): Fixed creating Windows service commands #8979

merged 3 commits into from
Nov 14, 2019

Conversation

WarsFeng
Copy link
Contributor

escaping " to "

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 14, 2019
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Nov 14, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2019
@codecov-io
Copy link

codecov-io commented Nov 14, 2019 •
edited
Loading

Codecov Report

Merging #8979 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8979      +/-   ##
==========================================
- Coverage   41.25%   41.24%   -0.01%     
==========================================
  Files         546      546              
  Lines       71037    71037              
==========================================
- Hits        29303    29301       -2     
- Misses      38015    38017       +2     
  Partials     3719     3719
Impacted Files Coverage Δ
models/repo_list.go 73.14% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e6d76...7804294. Read the comment docs.

@zeripath zeripath merged commit c9b564c into go-gitea:master Nov 14, 2019
@zeripath
Copy link
Contributor

@WarsFeng I wonder if you'd be able to test #8964 to see if after that Gitea shuts down gracefully - e.g. it doesn't just drop ongoing connections.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WarsFeng @codecov-io @zeripath @lunny @techknowlogick @GiteaBot