Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reCAPTCHA API URL #9079

Closed
wants to merge 5 commits into from
Closed

Fix reCAPTCHA API URL #9079

wants to merge 5 commits into from

Conversation

mzch
Copy link
Contributor

@mzch mzch commented Nov 19, 2019 •
edited by lafriks
Loading

Fixes #7870

techknowlogick
techknowlogick previously requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value is RECAPTCHA_URL = https://www.google.com/recaptcha/ so this will fail for those who have set this to something else.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2019
@BaxAndrei
Copy link

@techknowlogick see this: #7870 (comment)

lafriks
lafriks requested changes Nov 19, 2019
View reviewed changes
modules/recaptcha/recaptcha.go Outdated Show resolved Hide resolved
@lafriks
Copy link
Member

lafriks commented Nov 19, 2019 •
edited
Loading

You are right, there is bug, see:
https://play.golang.org/p/9wG1S8TvS33

I recommended in review correct solution

@lafriks lafriks added this to the 1.11.0 milestone Nov 19, 2019
@lafriks lafriks changed the title Fixed a reCAPTCHA error Fixe reCAPTCHA API URL Nov 19, 2019
@lafriks lafriks changed the title Fixe reCAPTCHA API URL Fix reCAPTCHA API URL Nov 19, 2019
@techknowlogick techknowlogick dismissed their stale review November 19, 2019 20:55

dismissing my review

@codecov-io
Copy link

codecov-io commented Nov 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@eb0359c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9079   +/-   ##
=========================================
  Coverage          ?   41.12%           
=========================================
  Files             ?      548           
  Lines             ?    71437           
  Branches          ?        0           
=========================================
  Hits              ?    29376           
  Misses            ?    38346           
  Partials          ?     3715
Impacted Files Coverage Δ
modules/recaptcha/recaptcha.go 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0359c...9ebb5d6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2019
@zeripath
Copy link
Contributor

Oh damn. Mea culpa. Could we fix urljoin instead/aswell? It's crazy that it's doing this. It absolutely should not be doing this as it will likely be causing other bugs too.

@mzch
Copy link
Contributor Author

mzch commented Nov 19, 2019

I found another fix.

@mzch mzch closed this Nov 19, 2019
@lafriks
Copy link
Member

lafriks commented Nov 19, 2019

@zeripath it is doing everything correctly imho

@mzch
Copy link
Contributor Author

mzch commented Nov 20, 2019 •
edited
Loading

@BaxAndrei I think it comes from specs of ResolveReference()
https://github.com/go-gitea/gitea/blob/master/modules/util/url.go

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jolheiser jolheiser jolheiser approved these changes

@techknowlogick techknowlogick techknowlogick left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Recaptcha doesn't work
8 participants
@mzch @BaxAndrei @lafriks @codecov-io @zeripath @techknowlogick @jolheiser @GiteaBot