Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect issue if repo has configured external tracker. #9247

Merged
merged 10 commits into from
Dec 7, 2019
Merged

Redirect issue if repo has configured external tracker. #9247

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ec7400
Redirect issue if repo has configured external tracker.
davidsvantesson Dec 3, 2019
0f22161
Handle error
davidsvantesson Dec 3, 2019
ae864a9
Add tests for redirect
Dec 4, 2019
88b278e
Fix test consistency
Dec 4, 2019
e6ebdf4
Merge branch 'master' into redirect-external-issue
lunny Dec 5, 2019
2393d4d
Merge branch 'master' into redirect-external-issue
lafriks Dec 5, 2019
851277d
Merge branch 'master' into redirect-external-issue
lunny Dec 6, 2019
d285490
Merge branch 'master' into redirect-external-issue
lunny Dec 6, 2019
5f12a81
Merge branch 'master' into redirect-external-issue
lunny Dec 6, 2019
28bbf31
Merge branch 'master' into redirect-external-issue
techknowlogick Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/doc/usage/linked-references.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ In the examples, `User1/Repo1` refers to the repository where the reference is u
| `User1/Repo1!1234` | yes | N/A | A link to _PR_ 1234 for `User1/Repo1` |
| `UserZ/RepoZ#1234` | N/A | no | A link to issue/pull 1234 in `UserZ/RepoZ` |
| `UserZ/RepoZ!1234` | N/A | no | A link to issue/pull 1234 in `UserZ/RepoZ` |
| _Not supported_ | N/A | yes | A link to _external issue_ 1234 for `UserZ/RepoZ` |
| `UserZ/RepoZ#1234` | N/A | yes | A link to _external issue_ 1234 for `UserZ/RepoZ` |
| `UserZ/RepoZ!1234` | N/A | yes | A link to _PR_ 1234 for `UserZ/RepoZ` |
| **Alphanumeric issue IDs:** | - | - | - |
| `AAA-1234` | yes | N/A | A link to _external issue_ `AAA-1234` for `User1/Repo1` |
Expand Down
14 changes: 14 additions & 0 deletions routers/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"code.gitea.io/gitea/modules/git"
issue_indexer "code.gitea.io/gitea/modules/indexer/issues"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/markup"
"code.gitea.io/gitea/modules/markup/markdown"
"code.gitea.io/gitea/modules/notification"
"code.gitea.io/gitea/modules/setting"
Expand Down Expand Up @@ -605,6 +606,19 @@ func commentTag(repo *models.Repository, poster *models.User, issue *models.Issu

// ViewIssue render issue view page
func ViewIssue(ctx *context.Context) {
extIssueUnit, err := ctx.Repo.Repository.GetUnit(models.UnitTypeExternalTracker)
if err == nil && extIssueUnit != nil {
if extIssueUnit.ExternalTrackerConfig().ExternalTrackerStyle == markup.IssueNameStyleNumeric {
lafriks marked this conversation as resolved.
Show resolved Hide resolved
metas := ctx.Repo.Repository.ComposeMetas()
metas["index"] = ctx.Params(":index")
ctx.Redirect(com.Expand(extIssueUnit.ExternalTrackerConfig().ExternalTrackerFormat, metas))
return
}
} else if err != nil && !models.IsErrUnitTypeNotExist(err) {
ctx.ServerError("GetUnit", err)
return
}

issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
if err != nil {
if models.IsErrIssueNotExist(err) {
Expand Down