Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NewCommitStatus (#9434) #9435

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Conversation

jolheiser
Copy link
Member

Backport to release/v1.10

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 19, 2019
@techknowlogick techknowlogick added this to the 1.10.2 milestone Dec 19, 2019
@zeripath
Copy link
Contributor

Make lg-tm work

@zeripath
Copy link
Contributor

Oh come on lg-tm

@zeripath
Copy link
Contributor

Really?!

@sapk
Copy link
Member

sapk commented Dec 19, 2019

LGTM should work

@zeripath
Copy link
Contributor

It's clearly not though... LGTM

@zeripath zeripath added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2019
@zeripath
Copy link
Contributor

Still not working? Is it because we're both managers?

@sapk
Copy link
Member

sapk commented Dec 19, 2019

I think it is just the bot that is lost. (one more LGTM because why not)

@sapk
Copy link
Member

sapk commented Dec 19, 2019

Seems strange also that codecov doesn't have commented after CI.

@sapk sapk merged commit a276aaf into go-gitea:release/v1.10 Dec 19, 2019
@jolheiser jolheiser deleted the backport_9434_3 branch December 19, 2019 23:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants