fix: fill in ssh key title on setting of repo #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
|
Looking at the code from #683 it looks like it will overwrite a value if it is already set. Should this be wrapped as if someone has already put in a value I don't think it should change what the user put in. Tell me if this should be a new issue and I can change it but this is fixing the code anyway so maybe this could be used for that... |
|
True, @appleboy please add a check if the title is empty before writing to it |
bkcsoft
reviewed
Feb 16, 2017
public/js/index.js
Outdated
| @@ -1493,7 +1493,8 @@ $(function () { | |||
| $("#ssh-key-content").on('change paste keyup',function(){ | |||
| var value = $(this).val(); | |||
There was a problem hiding this comment.
Is this necessary? Why not var arrays = $(this).val().split(" ") ?
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related PR: #863