Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backspace in SimpleMDE #9545

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Fix backspace in SimpleMDE #9545

merged 1 commit into from
Dec 30, 2019

Conversation

zeripath
Copy link
Contributor

The SimpleMDE backspace function refers to a trigger method of the textarea - which is not always present. This simple fix checks if the trigger is there before attempting to run it.

I'm not certain what is supposed to be being triggered here @blueworrybear do you have any more information?

Fix #9493

@zeripath zeripath added this to the 1.11.0 milestone Dec 30, 2019
@zeripath zeripath added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Dec 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #9545 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9545      +/-   ##
==========================================
+ Coverage   42.07%   42.08%   +<.01%     
==========================================
  Files         574      574              
  Lines       75243    75243              
==========================================
+ Hits        31662    31665       +3     
  Misses      39667    39667              
+ Partials     3914     3911       -3
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/check.go 50.7% <0%> (+2.11%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59536c...816fbd3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2019
@zeripath zeripath merged commit c2d854c into go-gitea:master Dec 30, 2019
@zeripath zeripath deleted the fix-9493 branch December 30, 2019 17:11
@zeripath
Copy link
Contributor Author

I've merged this but I'm not certain that the original reason why the trigger was there is actually covered.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backspace not working in new SimpleMDE on Issue/Commment
5 participants