Fix nil reference in repo generation #9660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9660 +/- ##
=========================================
+ Coverage 42.1% 42.1% +<.01%
=========================================
Files 584 584
Lines 77485 77486 +1
=========================================
+ Hits 32625 32627 +2
+ Misses 40848 40846 -2
- Partials 4012 4013 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
guillep2k
approved these changes
Jan 9, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jan 9, 2020
GiteaBot
added
lgtm/done
|
please send backport |
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Jan 9, 2020
* Fix nil reference Signed-off-by: jolheiser <john.olheiser@gmail.com> * Tighten Signed-off-by: jolheiser <john.olheiser@gmail.com>
zeripath
pushed a commit
that referenced
this pull request
Jan 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9659
When no
.gitea/templatefile is found,nilis returned. This is needed so we don't attempt expansions unless necessary, but it can lead to a nil reference in this case.