Fix SimpleMDE quote reply #9757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9757 +/- ##
==========================================
+ Coverage 42.31% 42.32% +0.01%
==========================================
Files 599 600 +1
Lines 78324 78357 +33
==========================================
+ Hits 33141 33168 +27
- Misses 41127 41134 +7
+ Partials 4056 4055 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Jan 14, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Jan 14, 2020
GiteaBot
added
lgtm/done
sapk
approved these changes
Jan 14, 2020
|
please send backport |
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Jan 14, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
sapk
added a commit
that referenced
this pull request
Jan 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9657
SimpleMDE cannot have its value set by normal means (that I can find, anyways) and must be set using the object. This PR saves the auto-initialized object to a scope where quote reply can reach it and set the value appropriately.
Unfortunately, I couldn't find a way to force the object to focus, so it doesn't currently scroll once it sets the value...but it's arguably better than not doing anything.