[WIP] Add NOT NULL constraints to repository #978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
commented
Feb 19, 2017
| return err | ||
| } | ||
|
|
||
| if err := sess.Sync2(new(RepoV17)); err != nil { |
There was a problem hiding this comment.
I had assumed that calling Sync2(..) would add the new NOT NULL constraints to the table, but it doesn't seem to be working.
There was a problem hiding this comment.
So what should I do?
There was a problem hiding this comment.
I think you have to write SQL yourself.
ethantkoenig
changed the title
|
This will be more annoying than I had initially thought, since SQLite and TiDB don't support adding constraints to existing columns. I'll put this on hold for now. |
tboerger
added
lgtm/need 2
delvh
added
issue/not-a-bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#962
I'm having trouble with my migration; right now, it does not actually add
NOT NULLconstraints to the existing columns of therepositorytable. If someone who knows what they're doing could point me in the right direction, I would appreciate it! 😄I've tested locally using Postgres 9.5.5