-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pages command #9811
feat: add pages command #9811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9811 +/- ##
==========================================
- Coverage 42.22% 42.17% -0.05%
==========================================
Files 603 604 +1
Lines 78881 78956 +75
==========================================
- Hits 33309 33303 -6
- Misses 41495 41576 +81
Partials 4077 4077
Continue to review full report at Codecov.
|
If we didn't give a |
Can't we detect request domain name in go code if behind reverse proxy? |
Or we could allow setting in app.ini to start listener on other port/socket for this |
Further more, I think we could implement the pages. |
I open early this PR, to discuss about it because I also hesitate on various design. First I was thinking that it was better to keep it separate (even from config file and maybe a separate binary) to be like a separate micro service that could scale. But I also see benefit to keep it inside gitea and directly load from config file and even integrate it in gitea (listening on another port but we have to warn/check domain limits). For domain detection behind proxy it is possible. The proxy just have to set some header but that near standard. |
If this service is built into gitea directly right checks and more features could be created more easier than it would be if they are separate |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
This pull request has been automatically closed because of inactivity. You can re-open it if needed. |
This new command "proxy" the raw API (should be under another domain for security) with mime-type and more user friendly url. This command need a running gitea
How to use it :
Things to improve :
(in short everything 😄)
Issues related: #9305 #3834 #1721 #8152