Fix wrong hint when status checking is running on pull request view #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
guillep2k
reviewed
Jan 20, 2020
modules/structs/commit_status.go
Outdated
| ) | ||
|
|
||
| // IsWorseThan returns true if this State is worse than the given State | ||
| func (css CommitStatusState) IsWorseThan(css2 CommitStatusState) bool { |
There was a problem hiding this comment.
Or NoBetterThan ? :)
NoBetterThan sounds good too. My problem was that the old name implied < but the function acts like <=.
There was a problem hiding this comment.
Hmm... It looks like there is a genuine total order here. An alternative might be:
type CommitStatus int
const (
CommitStatusPending CommitStatus = 0
...
)
func (c CommitStatus) String() {
switch c {
case CommitStatusPending:
return "pending"
...
}
}Then just use normal operators for the state.
There was a problem hiding this comment.
@zeripath I will left this other PRs to keep this PR clear.
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/fix_pr_status_check
branch
4 times, most recently
from
0f4fb39
to
4312976
Compare
Codecov Report
@@ Coverage Diff @@
## master #9886 +/- ##
=========================================
Coverage ? 42.28%
=========================================
Files ? 608
Lines ? 79392
Branches ? 0
=========================================
Hits ? 33570
Misses ? 41680
Partials ? 4142
Continue to review full report at Codecov.
|
6543
reviewed
Jan 21, 2020
6543
reviewed
Jan 21, 2020
lunny
force-pushed
the
lunny/fix_pr_status_check
branch
from
4312976
to
3320ba5
Compare
6543
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/need 1
guillep2k
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 22, 2020
…o-gitea#9886) * Fix wrong hint when status checking is running on pull request view * fix lint * fix test * fix test * fix wrong tmpl * fix import * rename function name
|
lable: backport/done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all required status check were running, it will display some required status check failed.
This PR will fix that. There are more states to check about the status check.
Fix #9394